want some suggestion on how to improve it